[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876360#comment-14876360
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39899186
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -395,31 +510,23 @@ public IpDeployer getIpDeployer(Network network) {
@Override
public boolean applyFWRules(Network network, List<? extends
FirewallRule> rules) throws ResourceUnavailableException {
- s_logger.debug("Handling applyFWRules for network " +
network.getName() + " with " + rules.size() + " FWRules");
- if (rules != null && rules.size() == 1 &&
rules.iterator().next().getType().equals(FirewallRuleType.System)) {
+ if (rules.size() == 1 &&
rules.iterator().next().getType().equals(FirewallRuleType.System)) {
--- End diff --
Check that ``rules`` is not null and respond accordingly (e.g. throw an
InvalidParameterException).
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
