[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876395#comment-14876395
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39900272
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -493,6 +676,15 @@ protected boolean isL3Network(Long offeringId) {
||
_ntwkOfferingSrvcDao.areServicesSupportedByNetworkOffering(offeringId,
Service.StaticNat);
}
+ private String getPreConfiguredDomainTemplateName(Network network,
NetworkOffering networkOffering) {
+ if (network.getVpcId() != null) {
+ return
_configDao.getValue(NuageVspManager.NuageVspVpcDomainTemplateName.key());
+ } else if (networkOffering.getGuestType() ==
Network.GuestType.Shared) {
+ return
_configDao.getValue(NuageVspManager.NuageVspSharedNetworkDomainTemplateName.key());
+ }
+ return
_configDao.getValue(NuageVspManager.NuageVspIsolatedNetworkDomainTemplateName.key());
--- End diff --
Why not set a local variable with the value to passed into
``_configDao.getValue(..)`` to make the method more concise and DRY?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
