[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953314#comment-14953314
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41775751
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
---
@@ -19,26 +19,26 @@
package com.cloud.agent.api.guru;
-import java.util.List;
-import java.util.Map;
-
import com.cloud.agent.api.Answer;
import com.cloud.agent.api.Command;
public class ReserveVmInterfaceVspAnswer extends Answer {
- public List<Map<String, String>> _interfaceDetails;
-
- public ReserveVmInterfaceVspAnswer(Command cmd, List<Map<String,
String>> interfaceDetails, String details) {
+ public ReserveVmInterfaceVspAnswer(Command cmd, String details) {
--- End diff --
Why does this class exist? It adds no state or behavior to the ``Answer``
base class. Why not simply use ``Answer`` in this circumstance?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
