[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953331#comment-14953331
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41776261
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
return _vmUuid;
}
+ public boolean isExpungingState() {
+ return _isExpungingState;
+ }
+
+ public static class Builder extends CmdBuilder<DeallocateVmVspCommand>
{
+ private String _networkUuid;
+ private String _nicFromDdUuid;
+ private String _nicMacAddress;
+ private String _nicIp4Address;
+ private boolean _isL3Network;
+ private boolean _isSharedNetwork;
+ private String _vpcUuid;
+ private String _networksDomainUuid;
+ private String _vmInstanceName;
+ private String _vmUuid;
+ private boolean _isExpungingState;
+
+ public Builder networkUuid(String networkUuid) {
+ this._networkUuid = networkUuid;
+ return this;
+ }
+
+ public Builder nicFromDbUuid(String nicFromDbUuid) {
+ this._nicFromDdUuid = nicFromDbUuid;
+ return this;
+ }
+
+ public Builder nicMacAddress(String nicMacAddress) {
+ this._nicMacAddress = nicMacAddress;
+ return this;
+ }
+
+ public Builder nicIp4Address(String nicIp4Address) {
+ this._nicIp4Address = nicIp4Address;
+ return this;
+ }
+
+ public Builder isL3Network(boolean isL3Network) {
+ this._isL3Network = isL3Network;
+ return this;
+ }
+
+ public Builder isSharedNetwork(boolean isSharedNetwork) {
+ this._isSharedNetwork = isSharedNetwork;
+ return this;
+ }
+
+ public Builder vpcUuid(String vpcUuid) {
+ this._vpcUuid = vpcUuid;
+ return this;
+ }
+
+ public Builder networksDomainUuid(String networksDomainUuid) {
+ this._networksDomainUuid = networksDomainUuid;
+ return this;
+ }
+
+ public Builder vmInstanceName(String vmInstanceName) {
+ this._vmInstanceName = vmInstanceName;
+ return this;
+ }
+
+ public Builder vmUuid(String vmUuid) {
+ this._vmUuid = vmUuid;
+ return this;
+ }
+
+ public Builder isExpungingState(boolean isExpungingState) {
+ this._isExpungingState = isExpungingState;
+ return this;
+ }
+
+ @Override
+ public DeallocateVmVspCommand build() {
+ return new DeallocateVmVspCommand(_networkUuid,_nicFromDdUuid,
_nicMacAddress, _nicIp4Address, _isL3Network, _isSharedNetwork, _vpcUuid,
+ _networksDomainUuid, _vmInstanceName, _vmUuid,
_isExpungingState);
+ }
+ }
+
@Override
public boolean executeInSequence() {
return false;
}
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+
+ DeallocateVmVspCommand that = (DeallocateVmVspCommand) o;
+
+ if (_isExpungingState != that._isExpungingState) return false;
+ if (_isL3Network != that._isL3Network) return false;
+ if (_isSharedNetwork != that._isSharedNetwork) return false;
+ if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid)
: that._networkUuid != null) return false;
+ if (_networksDomainUuid != null ?
!_networksDomainUuid.equals(that._networksDomainUuid) :
that._networksDomainUuid != null)
+ return false;
+ if (_nicFromDdUuid != null ?
!_nicFromDdUuid.equals(that._nicFromDdUuid) : that._nicFromDdUuid != null)
+ return false;
+ if (_nicIp4Address != null ?
!_nicIp4Address.equals(that._nicIp4Address) : that._nicIp4Address != null)
+ return false;
+ if (_nicMacAddress != null ?
!_nicMacAddress.equals(that._nicMacAddress) : that._nicMacAddress != null)
+ return false;
+ if (_vmInstanceName != null ?
!_vmInstanceName.equals(that._vmInstanceName) : that._vmInstanceName != null)
+ return false;
+ if (_vmUuid != null ? !_vmUuid.equals(that._vmUuid) : that._vmUuid
!= null) return false;
+ if (_vpcUuid != null ? !_vpcUuid.equals(that._vpcUuid) :
that._vpcUuid != null) return false;
+
+ return true;
+ }
+
+ @Override
+ public int hashCode() {
+ int result = _networkUuid != null ? _networkUuid.hashCode() : 0;
+ result = 31 * result + (_nicFromDdUuid != null ?
_nicFromDdUuid.hashCode() : 0);
+ result = 31 * result + (_nicMacAddress != null ?
_nicMacAddress.hashCode() : 0);
+ result = 31 * result + (_nicIp4Address != null ?
_nicIp4Address.hashCode() : 0);
+ result = 31 * result + (_isL3Network ? 1 : 0);
+ result = 31 * result + (_isSharedNetwork ? 1 : 0);
+ result = 31 * result + (_vpcUuid != null ? _vpcUuid.hashCode() :
0);
+ result = 31 * result + (_networksDomainUuid != null ?
_networksDomainUuid.hashCode() : 0);
+ result = 31 * result + (_vmInstanceName != null ?
_vmInstanceName.hashCode() : 0);
+ result = 31 * result + (_vmUuid != null ? _vmUuid.hashCode() : 0);
+ result = 31 * result + (_isExpungingState ? 1 : 0);
+ return result;
+ }
--- End diff --
Please implement ``toString()`` to provide debugging state information for
debugging purposes.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
