[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953323#comment-14953323
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41775987
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsCommand.java
---
@@ -17,38 +17,28 @@
// under the License.
//
-package com.cloud.agent.api.guru;
+package com.cloud.agent.api.manager;
import com.cloud.agent.api.Command;
-public class ReleaseVmVspCommand extends Command {
+public class GetClientDefaultsCommand extends Command {
- String _networkUuid;
- String _vmUuid;
- String _vmInstanceName;
-
- public ReleaseVmVspCommand(String networkUuid, String vmUuid, String
vmInstanceName) {
+ public GetClientDefaultsCommand() {
super();
- this._networkUuid = networkUuid;
- this._vmUuid = vmUuid;
- this._vmInstanceName = vmInstanceName;
- }
-
- public String getNetworkUuid() {
- return _networkUuid;
}
- public String getVmUuid() {
- return _vmUuid;
+ @Override
+ public boolean executeInSequence() {
+ return false;
}
- public String getVmInstanceName() {
- return _vmInstanceName;
+ @Override
+ public boolean equals(Object obj) {
+ return super.equals(obj);
}
@Override
- public boolean executeInSequence() {
- return false;
+ public int hashCode() {
+ return super.hashCode();
}
-
-}
+}
--- End diff --
No need to override ``equals`` or ``hashCode``. Simply add a comment that
the super class implementations are acceptable because this class does not
track any state in addition to the super class.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
