[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953830#comment-14953830
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41806186
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -403,20 +412,36 @@ private Answer executeRequest(TrashNetworkVspCommand
cmd) {
private Answer executeRequest(ApplyStaticNatVspCommand cmd) {
try {
isNuageVspElementLoaded();
-
_nuageVspElementClient.applyStaticNats(cmd.getNetworkDomainUuid(),
cmd.getVpcOrSubnetUuid(), cmd.isL3Network(), cmd.getStaticNatDetails());
+
_nuageVspElementClient.applyStaticNats(cmd.getNetworkDomainUuid(),
cmd.getNetworkUuid(), cmd.getVpcOrSubnetUuid(), cmd.isL3Network(),
+ cmd.isVpc(), cmd.getStaticNatDetails());
return new ApplyStaticNatVspAnswer(cmd, true, "Applied Static
NAT to VSP network mapping to " + cmd.getVpcOrSubnetUuid());
} catch (Exception e) {
+ s_logger.error("Failure during " + cmd, e);
return new ApplyStaticNatVspAnswer(cmd, e);
}
}
+ private Answer executeRequest(ImplementVspCommand cmd) {
+ try {
+ isNuageVspElementLoaded();
+ boolean success =
_nuageVspElementClient.implement(cmd.getNetworkId(),
cmd.getNetworkDomainUuid(), cmd.getNetworkUuid(), cmd.getNetworkName(),
cmd.getVpcOrSubnetUuid(), cmd.isL2Network(),
+ cmd.isL3Network(), cmd.isVpc(), cmd.isShared(),
cmd.getDomainTemplateName(), cmd.isFirewallServiceSupported(),
cmd.getDnsServers(), cmd.getIngressFirewallRules(),
+ cmd.getEgressFirewallRules(), cmd.getAcsFipUuid(),
cmd.isEgressDefaultPolicy());
+ return new ImplementVspAnswer(cmd, success, "Implemented
network in VSP " + cmd.getNetworkUuid());
+ } catch (Exception e) {
--- End diff --
Why are all unchecked and checked exceptions being caught? It seems like
we should only be catching the expected checked exceptions, and allow unchecked
exceptions simply bubble out.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
