[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953869#comment-14953869
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41807645
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java
---
@@ -21,10 +21,10 @@
public interface NuageVspApiClient {
- public void login() throws Exception;
+ void login() throws Exception;
- public void setNuageVspHost(String restRelativePath, String[]
cmsUserInfo, int noofRetry, int retryInterval);
+ void setNuageVspHost(String restRelativePath, String[] cmsUserInfo,
int noofRetry, int retryInterval, String nuageVspCmsId);
- public String executeRestApi(String method, String resource, String
resourceId, String childResource, Object entityDetails, String resourceFilter,
String proxyUserUuid,
- String proxyUserDomainuuid) throws Exception;
+ String executeRestApi(String method, String resource, String
resourceId, String childResource, Object entityDetails, String resourceFilter,
String proxyUserUuid,
+ String proxyUserDomainuuid) throws
Exception;
--- End diff --
This ``throws`` is too broad. Please enumerate the expected checked
exceptions to be thrown.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
