[
https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977065#comment-14977065
]
ASF GitHub Bot commented on CLOUDSTACK-8991:
--------------------------------------------
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/989
CLOUDSTACK-8991 - IP address is not removed from VR even after disabling
static NAT
This PR fixes the Public IP removal form the virtual routers. It also
improves the existing test_network.py.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack
fix/cleanup_vr_ips-CLOUDSTACK-8991
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 99318caa67f25932b652ea53c1742b6c1e5b0927
Author: Wilder Rodrigues <[email protected]>
Date: 2015-10-27T18:45:34Z
CLOUDSTACK-8991 - Make sure the public IP is removed form the router before
checking
- Adding proper logger to the tests
- Changing message that was copied/pasted from another assert
commit 7197cf2e24a02dbc5cd4c1964e7c8baadc112340
Author: Wilder Rodrigues <[email protected]>
Date: 2015-10-27T18:46:13Z
CLOUDSTACK-8991 - Remove public IP form interface in case add = false
commit e6a3b3bf9cf03ffa189db0a7df81579a57148d8e
Author: Wilder Rodrigues <[email protected]>
Date: 2015-10-27T18:46:48Z
CLOUDSTACK-8991 - Process the IPs that have been removed
commit 081c6a965e3750df1a4b6c3746a0ffb1b95b62b3
Author: Wilder Rodrigues <[email protected]>
Date: 2015-10-27T20:03:10Z
CLOUDSTACK-8991 - Use the correct IP address object
----
> IP address is not removed from VR even after disabling static NAT
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8991
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Priority: Blocker
>
> Test for port forwarding on source NAT ... === TestName:
> test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... === TestName:
> test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
> ok
> Test for reboot router ... === TestName: test_reboot_router | Status :
> SUCCESS ===
> ok
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
> FAILED ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED
> ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status
> : FAILED ===
> FAIL
> ======================================================================
> FAIL: Test for Router rules for network rules on acquired public IP
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper
> return func(self, *args, **kwargs)
> File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py",
> line 1248, in test_network_rules_acquired_public_ip
> not removed from VR even after disabling statin NAT")
> AssertionError: IP address is not removed from VR even after
> disabling statin NAT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
