[
https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977123#comment-14977123
]
ASF GitHub Bot commented on CLOUDSTACK-8991:
--------------------------------------------
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/989#discussion_r43184047
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -602,9 +610,8 @@ def compare(self, bag):
if self.dev in bag.keys():
for address in bag[self.dev]:
self.setAddress(address)
- if self.hasIP(ip):
- found = True
- if self.is_guest_gateway(address, ip):
+ if (self.hasIP(ip) or self.is_guest_gateway(address,
ip)) and addess["add"]:
+ logging.debig("The IP address in '%s' will be
configured" % address)
--- End diff --
Is logging.debig correct? Shouldn't this be logging.debug?
> IP address is not removed from VR even after disabling static NAT
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8991
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Priority: Blocker
>
> Test for port forwarding on source NAT ... === TestName:
> test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... === TestName:
> test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
> ok
> Test for reboot router ... === TestName: test_reboot_router | Status :
> SUCCESS ===
> ok
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
> FAILED ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED
> ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status
> : FAILED ===
> FAIL
> ======================================================================
> FAIL: Test for Router rules for network rules on acquired public IP
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper
> return func(self, *args, **kwargs)
> File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py",
> line 1248, in test_network_rules_acquired_public_ip
> not removed from VR even after disabling statin NAT")
> AssertionError: IP address is not removed from VR even after
> disabling statin NAT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
