[
https://issues.apache.org/jira/browse/CLOUDSTACK-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037419#comment-15037419
]
ASF GitHub Bot commented on CLOUDSTACK-6276:
--------------------------------------------
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-161537378
LGTM. tested
(1) create affinity group in project
(2) deploy vm with affinity group
(3) update vm affinity group
(4) delete affinity group.
one suggestion,
```
diff --git
a/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
b/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
index 5da1f88..e2de220 100644
---
a/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
+++
b/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
@@ -434,7 +434,7 @@ public class AffinityGroupServiceImpl extends
ManagerBase implements AffinityGro
throw new InvalidParameterValueException("Unable to find
affinity group by id " + affinityGroupId);
} else {
// verify permissions
- _accountMgr.checkAccess(caller, null, true, owner, ag);
+ _accountMgr.checkAccess(caller, AccessType.OperateEntry,
true, owner, ag);
// Root admin has access to both VM and AG by default, but
make sure the
// owner of these entities is same
if (caller.getId() == Account.ACCOUNT_ID_SYSTEM ||
_accountMgr.isRootAdmin(caller.getId())) {
```
> Affinity Groups within projects
> -------------------------------
>
> Key: CLOUDSTACK-6276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6276
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Ingo Jochim
>
> Hello,
> I like to have the features "Affinity Group" and "Project" combined.
> As far as I know I cannot use Affinity Groups within Projects.
> Thanks and regards,
> Ingo
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
