[
https://issues.apache.org/jira/browse/CLOUDSTACK-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091141#comment-15091141
]
ASF GitHub Bot commented on CLOUDSTACK-9211:
--------------------------------------------
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1310#discussion_r49279282
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1895,6 +1896,9 @@ protected StartAnswer execute(StartCommand cmd) {
postDiskConfigBeforeStart(vmMo, vmSpec, sortedDisks,
ideControllerKey, scsiControllerKey, iqnToPath, hyperHost, context);
+ //Sets video card memory to the one provided in detail
svga.vramSize (if provided), 64MB was always set before
--- End diff --
I think a comment like this would be better located in a Javadoc style
comment above the `postVideoCardMemoryConfigBeforeStart` method itself, along
with brief descriptions of the parameters involved. This could make it easier
to read/understand going forward. :)
> Support passing vRAM size over to Esxi hypervisor to support 3D GPU on Vmware
> -----------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9211
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9211
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.8.0
> Reporter: Nicolas Vazquez
> Fix For: 4.8.0
>
>
> CS support passing hypervisor options by creating entries in
> {{vm_template_details}} or {{user_vm_details}}
> To enable software 3D GPU 4 options needs to be added:
> ||name||value||
> |mks.enable3d|true|
> |mks.use3dRenderer|automatic|
> |svga.autodetect|false|
> |svga.vramSize|(size in KB) e.g. 131072|
> Currently all options except {{svga.vramSize}} works, VMs always get
> configured with default 64Mb videoRAM instead of the one provided on the
> option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
