[
https://issues.apache.org/jira/browse/CLOUDSTACK-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098997#comment-15098997
]
ASF GitHub Bot commented on CLOUDSTACK-9211:
--------------------------------------------
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-171798749
Thanks for taking the time to add the descriptions and refactoring,
@nvazquez. It has helped readability quite a bit. :)
Now, in case you're interested in improving this code *even further*, may I
suggest breaking down the `postVideoCardMemoryConfigBeforeStart` method a bit
more? I like what you did separating it into two, but there are still quite a
few conditionals within each other and that makes the whole thing look
convoluted, not to mention adding up to cyclomatic complexity. Bonus points for
adding javadoc style descriptions to the new methods you create like you did to
the existing ones.
My last suggestion would be to write some test cases (unit tests) for the
methods you've created. After that, as far as I can assess, this PR will be
perfect. :)
> Support passing vRAM size over to Esxi hypervisor to support 3D GPU on Vmware
> -----------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9211
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9211
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Affects Versions: 4.8.0
> Reporter: Nicolas Vazquez
> Fix For: 4.8.0
>
>
> CS support passing hypervisor options by creating entries in
> {{vm_template_details}} or {{user_vm_details}}
> To enable software 3D GPU 4 options needs to be added:
> ||name||value||
> |mks.enable3d|true|
> |mks.use3dRenderer|automatic|
> |svga.autodetect|false|
> |svga.vramSize|(size in KB) e.g. 131072|
> Currently all options except {{svga.vramSize}} works, VMs always get
> configured with default 64Mb videoRAM instead of the one provided on the
> option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
