[
https://issues.apache.org/jira/browse/CLOUDSTACK-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116305#comment-15116305
]
ASF GitHub Bot commented on CLOUDSTACK-9252:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-174734613
@serg38, I did not know that, giving your explanation I rest my arguments ;)
@nvazquez, you changed the method “getMountPoint” to receive a NFS protocol
version, that method uses the version in another method that is called “mount”,
in which you added a conditional to check if the version != null, then you add
it to the mount command. I am ok with that code.
I only have a doubt, if the version may be required why aren’t you using it
in most of the code? It seems that you mostly call the “getMountPoint” method
as “mountService.getMountPoint(secondaryStorageUrl, null)”.
Actually, the only time I see you using the NFS protocol version is when
you use the “prepareSecondaryStorageStore” method. As @serg38 nicely explained
that there are vendors that do not support version negotiation, wouldn’t that
be the case to always use the version that you already have in hand?
> Support configurable NFS version for Secondary Storage mounts
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9252
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Reporter: Nicolas Vazquez
>
> After starting secondary storage VM, secondary storage tries to be mounted
> but fails with error: {{Protocol family not supported}}
> It was found out that adding {{-o vers=X}} to mount command it would work,
> where {{X}} is the desired NFS version to use.
> If it is desired to mount a store with a specific NFS version, it has passed
> in {{image_store_details}} table for a store with id {{Y}} as a property:
> ||store_id||||name||value||
> |Y|nfs.version|X|
> Where X stands for NFS version
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
