[
https://issues.apache.org/jira/browse/CLOUDSTACK-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124122#comment-15124122
]
ASF GitHub Bot commented on CLOUDSTACK-9252:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-176948581
It is better now.
I only have to point two things out.
1 – About the class “com.cloud.storage.ImageStoreDetailsUtil” that you
created. You are using static methods, and those static methods are using
“variables” that you want to set using the spring suite. The way you did will
not work; to my knowledge, those attributes will not be set by spring. If you
want to set them with spring you should annotate the class with “@component”,
then the object will be in the spring life cycle, and those attributes will be
set properly. Of course, if you do that, remove the static from those methods
(getNfsVersionByUuid, getNfsVersion) and then you would have to inject the
"ImageStoreDetailsUtil" object into those classes that want to use the
“getNfsVersion” methods.
2 – The java doc you created for
“com.cloud.storage.ImageStoreDetailsUtil.getNfsVersion(long)” is pretty nice. I
would like to see the same in
“com.cloud.storage.ImageStoreDetailsUtil.getNfsVersionByUuid(String)”.
Moreover, I think those methods deserve some test case.
> Support configurable NFS version for Secondary Storage mounts
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9252
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9252
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Reporter: Nicolas Vazquez
>
> After starting secondary storage VM, secondary storage tries to be mounted
> but fails with error: {{Protocol family not supported}}
> It was found out that adding {{-o vers=X}} to mount command it would work,
> where {{X}} is the desired NFS version to use.
> If it is desired to mount a store with a specific NFS version, it has passed
> in {{image_store_details}} table for a store with id {{Y}} as a property:
> ||store_id||||name||value||
> |Y|nfs.version|X|
> Where X stands for NFS version
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
