[
https://issues.apache.org/jira/browse/CLOUDSTACK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181843#comment-15181843
]
ASF GitHub Bot commented on CLOUDSTACK-9287:
--------------------------------------------
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55127619
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw(final
PrivateGateway gateway, final List
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
+ final Network privateNetwork =
_networkModel.getNetwork(gateway.getNetworkId());
+
boolean result = true;
for (final DomainRouterVO domainRouterVO : routers) {
- result = result && networkTopology.applyNetworkACLs(network,
rules, domainRouterVO, isPrivateGateway);
+ final NicProfile nicProfile =
_networkModel.getNicProfile(domainRouterVO, privateNetwork.getId(), null);
+ if (nicProfile != null) {
+ result = result &&
networkTopology.applyNetworkACLs(network, rules, domainRouterVO,
isPrivateGateway);
--- End diff --
@wilderrodrigues I think it might be more readable if changed to:
`return networkTopology.applyNetworkACLs(network, rules, domainRouterVO,
isPrivateGateway);`
Thanks.
> As an User I want to use Private Gateways with Redundant VPCs
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9287
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9287
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0, 4.7.0, 4.8.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Priority: Critical
> Fix For: 4.9.0
>
>
> Currently we cannot:
> 1. Delete the gateway from a rVPC
> 2. Restart a rVPC that has a private gateway configured
> 3. Have redundancy with private gateway on a rVPC: once master dies the pvt
> gw is not properly configured in the new master router
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
