[
https://issues.apache.org/jira/browse/CLOUDSTACK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233720#comment-15233720
]
ASF GitHub Bot commented on CLOUDSTACK-9287:
--------------------------------------------
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1483#discussion_r59121072
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final
PrivateGateway gateway) throws Concurr
}
}
- return result > 0 ? true : false;
+ return result == routers.size() ? true : false;
}
--- End diff --
This line is equivallent to
```Java
return result == routers.size();
```
please take the ternary operator away
> As an User I want to use Private Gateways with Redundant VPCs
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-9287
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9287
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0, 4.7.0, 4.8.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Priority: Critical
> Fix For: 4.9.0
>
>
> Currently we cannot:
> 1. Delete the gateway from a rVPC
> 2. Restart a rVPC that has a private gateway configured
> 3. Have redundancy with private gateway on a rVPC: once master dies the pvt
> gw is not properly configured in the new master router
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
