[
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199893#comment-15199893
]
ASF GitHub Bot commented on CLOUDSTACK-9297:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382
Ok @mike-tutkowski, now I believe I understand a little bit more of the
code.
You are reusing a method that already exist and returns the
StrategyPriority (you did not create that method to suffice your code). I was
misled by the name of the method, when I first saw it, I thought that the
method was used solely to check if it can or cannot proceed with the snapshot
when in fact it is used to do much more.
I believe "getSnapshotStrategy" would be a more suitable name.
Now that I understand what we have there, I am ok with that conditional as
it
is.
> delete snapshot without id is failing with Unable to determine the storage
> pool of the snapshot
> -----------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
> Reporter: Özhan Rüzgar Karaman
> Assignee: Mike Tutkowski
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
