[
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199758#comment-15199758
]
ASF GitHub Bot commented on CLOUDSTACK-9297:
--------------------------------------------
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197942848
The canHandle method is used by CloudStack's snapshot infrastructure to
determine which snapshot strategy to use.
For example, StorageSystemSnapshotStrategy returns either
StrategyPriority.HIGHEST or StrategyPriority.CANT_HANDLE whereas
XenserverSnapshotStrategy returns StrategyPriority.DEFAULT or
StrategyPriority.CANT_HANDLE.
That being the case, there are at least three options in play (and other
people can write custom snapshot strategies that they don't even check into the
CloudStack repo, so we can't easily just change the interface where canHandle
is declared).
As for this sentence:
“I see returning true as your revert was successful and returning false as
it failed (but it was OK for you to ask us to revert because canHandle properly
told you that you could do so)”
That was in regards to the revertSnapshot method. It sounds like you agree
with the exception being thrown there.
> delete snapshot without id is failing with Unable to determine the storage
> pool of the snapshot
> -----------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
> Reporter: Özhan Rüzgar Karaman
> Assignee: Mike Tutkowski
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
