[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238877#comment-15238877
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59513255
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/ListRolesCmd.java ---
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.acl;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.google.common.base.Strings;
+import org.apache.cloudstack.acl.Role;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.RoleResponse;
+
+import java.util.ArrayList;
+import java.util.List;
+
+@APICommand(name = ListRolesCmd.APINAME, description = "Lists dynamic
roles in CloudStack", responseObject = RoleResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ since = "4.9.0",
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin,
RoleType.DomainAdmin})
+public class ListRolesCmd extends BaseCmd {
+ public static final String APINAME = "listRoles";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType
= RoleResponse.class, description = "List role by role ID.")
+ private Long id;
+
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "List role by role name.")
+ private String roleName;
+
+ @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING,
description = "List role by role type, valid options are: Admin, ResourceAdmin,
DomainAdmin, User.")
+ private String roleType;
+
+ /////////////////////////////////////////////////////
+ /////////////////// Accessors ///////////////////////
+ /////////////////////////////////////////////////////
+
+ public Long getId() {
+ return id;
+ }
+
+ public String getName() {
+ return roleName;
+ }
+
+ public RoleType getRoleType() {
+ if (!Strings.isNullOrEmpty(roleType)) {
+ return RoleType.valueOf(roleType);
+ }
+ return null;
+ }
+
+ /////////////////////////////////////////////////////
+ /////////////// API Implementation///////////////////
+ /////////////////////////////////////////////////////
+
+ @Override
+ public String getCommandName() {
+ return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+ }
+
+ @Override
+ public long getEntityOwnerId() {
+ return Account.ACCOUNT_ID_SYSTEM;
+ }
+
+ @Override
+ public void execute() throws ResourceUnavailableException,
InsufficientCapacityException, ServerApiException,
ConcurrentOperationException, ResourceAllocationException,
NetworkRuleConflictException {
+ if (getId() != null && getId() < 1L) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
"Invalid role id provided");
+ }
+ List<Role> roles = roleService.findAllRolesBy(getId(), getName(),
getRoleType());
+ ListResponse<RoleResponse> response = new ListResponse<>();
+ List<RoleResponse> roleResponses = new ArrayList<>();
+ for (Role role : roles) {
+ if (role == null) {
+ continue;
+ }
+ RoleResponse roleResponse = new RoleResponse();
+ roleResponse.setId(role.getUuid());
+ roleResponse.setRoleName(role.getName());
+ roleResponse.setRoleType(role.getRoleType());
+ roleResponse.setDescription(role.getDescription());
+ roleResponse.setObjectName("role");
+ roleResponses.add(roleResponse);
+ }
+ response.setResponses(roleResponses);
+ response.setResponseName(getCommandName());
+ setResponseObject(response);
+ }
--- End diff --
same as create commands: factor out?
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
