[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238997#comment-15238997
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59523317
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java ---
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.acl;
+
+import com.cloud.user.Account;
+import com.google.common.base.Strings;
+import org.apache.cloudstack.acl.Role;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.RoleResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = CreateRoleCmd.APINAME, description = "Creates a role",
responseObject = RoleResponse.class,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ since = "4.9.0",
+ authorized = {RoleType.Admin})
+public class CreateRoleCmd extends BaseCmd {
+ public static final String APINAME = "createRole";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
required = true, description = "creates a role with this unique name")
+ private String roleName;
+
+ @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING,
required = true, description = "The type of the role, valid options are: Admin,
ResourceAdmin, DomainAdmin, User")
+ private String roleType;
+
+ @Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING,
description = "The description of the role")
+ private String roleDescription;
+
+ /////////////////////////////////////////////////////
+ /////////////////// Accessors ///////////////////////
+ /////////////////////////////////////////////////////
+
+ public String getRoleName() {
+ return roleName;
+ }
+
+ public RoleType getRoleType() {
+ return RoleType.fromString(roleType);
+ }
+
+ public String getRoleDescription() {
+ return roleDescription;
+ }
+
+ /////////////////////////////////////////////////////
+ /////////////// API Implementation///////////////////
+ /////////////////////////////////////////////////////
+
+ @Override
+ public String getCommandName() {
+ return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+ }
+
+ @Override
+ public long getEntityOwnerId() {
+ return Account.ACCOUNT_ID_SYSTEM;
+ }
+
+ @Override
+ public void execute() {
+ if (Strings.isNullOrEmpty(getRoleName())) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty
role name provided");
+ }
+ if (getRoleType() == null || getRoleType() == RoleType.Unknown) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
"Invalid role type provided");
+ }
+ CallContext.current().setEventDetails("Role: " + getRoleName() +
", type:" + getRoleType() + ", description: " + getRoleDescription());
+ Role role = roleService.createRole(getRoleName(), getRoleType(),
getRoleDescription());
+ if (role == null) {
+ throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
"Failed to create role");
+ }
+ RoleResponse response = new RoleResponse();
+ response.setId(role.getUuid());
+ response.setRoleName(role.getName());
+ response.setRoleType(role.getRoleType());
+ response.setResponseName(getCommandName());
+ response.setObjectName("role");
+ setResponseObject(response);
+ }
--- End diff --
I can do that, but won't make any difference. By keeping it in the
execute() we can keep the code that makes response in the same place. This is a
common pattern in several api Cmd classes.
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
