[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239012#comment-15239012
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59524315
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.acl;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface RoleService {
+
+ ConfigKey<Boolean> EnableDynamicApiChecker = new ConfigKey<>("Hidden",
Boolean.class, "dynamic.apichecker.enabled", "false",
+ "If set to true, this enables the dynamic role-based api
access checker and disables the default static role-based api access checker.",
+ true);
+
+ boolean isEnabled();
+ Role findRole(final Long id);
+ Role createRole(final String name, final RoleType roleType, final
String description);
+ boolean updateRole(final Role role, final String name, final RoleType
roleType, final String description);
+ boolean deleteRole(final Role role);
+
+ RolePermission findRolePermission(final Long id);
+ RolePermission createRolePermission(final Role role, final Rule rule,
final RolePermission.Permission permission, final String description);
+ boolean updateRolePermission(final RolePermission rolePermission,
final Rule rule, final RolePermission.Permission permission, final String
description);
+ boolean deleteRolePermission(final RolePermission rolePermission);
+
+ List<Role> findAllRolesBy(final Long id, final String name, final
RoleType roleType);
--- End diff --
@bhaisaab, you could split them or add a javadoc so users get a clue. If
the caller is in control splitting makes sense. They'd know what they are
passing anyway.
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
