[
https://issues.apache.org/jira/browse/CLOUDSTACK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292657#comment-15292657
]
ASF GitHub Bot commented on CLOUDSTACK-9180:
--------------------------------------------
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220512147
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 1
Errors: 4
Duration: 9h 31m 01s
```
**Summary of the problem(s):**
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created :
u'2016-05-20T01:01:48+0200', jobresult : {errorcode : 530, errortext : u'Failed
to delete network'}, cmd :
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid :
u'7419d6d0-1de7-11e6-9293-5254001daa61', jobstatus : 2, jobid :
u'63713d1c-6f2b-480f-a7a3-8f5bac6328bc', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'Network', accountid :
u'7419c212-1de7-11e6-9293-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```
```
ERROR: test suite for <class
'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
209, in run
self.setUp()
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
292, in setUp
self.setupContext(ancestor)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
315, in setupContext
try_run(context, names)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471,
in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py",
line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```
```
ERROR: test suite for <class
'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
209, in run
self.setUp()
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
292, in setUp
self.setupContext(ancestor)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
315, in setupContext
try_run(context, names)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471,
in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py",
line 293, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```
```
ERROR: test suite for <class
'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
209, in run
self.setUp()
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
292, in setUp
self.setupContext(ancestor)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
315, in setupContext
try_run(context, names)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471,
in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py",
line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```
```
FAIL: Test destroy(expunge) Virtual Machine
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line
646, in test_09_expunge_vm
self.assertEqual(list_vm_response,None,"Check Expunged virtual machine
is in listVirtualMachines response")
AssertionError: Check Expunged virtual machine is in listVirtualMachines
response
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_routers_6NRPKU/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_33_43_9O7LI4:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_33_43_9O7LI4/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_33_43_9O7LI4/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_33_43_9O7LI4/runinfo.txt)
**`/tmp/MarvinLogs/test_network_TL42E7:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_TL42E7/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_TL42E7/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_TL42E7/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_6NRPKU:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_6NRPKU/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_6NRPKU/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_6NRPKU/runinfo.txt)
Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
> Optimize concurrent VM deployment operation on same network
> -----------------------------------------------------------
>
> Key: CLOUDSTACK-9180
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9180
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Fix For: Future
>
>
> During VM deployment a check is performed to see if VR exists or not. If not
> it is created - first an entry is allocated in DB for VR and then it is
> deployed. The allocation logic is placed in a lock (based on network id) so
> that only one thread does the allocation. But the locking is implemented in a
> way such that all threads wait on that lock even when VR is already
> allocated. The correct approach would be to check if VR is allocated or not
> and acquire lock only when needed.
> This issue is more frequently seen when concurrently deploying VMs in basic
> zone as all threads try to acquire lock using the same network id. In
> advanced zone operations are spread across multiple networks and so less
> frequent.
> Refer to findOrDeployVirtualRouter() in RouterDeploymentDefinition.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
