[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293477#comment-15293477
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9180:
--------------------------------------------

Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1251#issuecomment-220628656
  
    
    
    ### CI RESULTS
    
    ```
    Tests Run: 82
      Skipped: 0
       Failed: 0
       Errors: 4
     Duration: 8h 31m 38s
    ```
    
    **Summary of the problem(s):**
    ```
    ERROR: test suite for <class 
'integration.smoke.test_internal_lb.TestInternalLb'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
228, in run
        self.tearDown()
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
351, in tearDown
        self.teardownContext(ancestor)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
367, in teardownContext
        try_run(context, names)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
        return func()
      File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
847, in tearDownClass
        raise Exception("Cleanup failed with %s" % e)
    Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-20T11:25:42+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete template'}, cmd : 
u'org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd', userid : 
u'e34c6f59-1e44-11e6-9276-5254001daa61', jobstatus : 2, jobid : 
u'88b5638b-7732-4e6d-9ccf-9a3be346b281', jobresultcode : 530, jobinstanceid : 
u'3cd24df8-bd13-4250-8706-a43e9e42c754', jobresulttype : u'object', 
jobinstancetype : u'Template', accountid : 
u'e34c5a5a-1e44-11e6-9276-5254001daa61'}
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
    ```
    
    ```
    ERROR: test suite for <class 
'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
        self.setUp()
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
        self.setupContext(ancestor)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
        try_run(context, names)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
    ```
    
    ```
    ERROR: test suite for <class 
'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
        self.setUp()
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
        self.setupContext(ancestor)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
        try_run(context, names)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
    ```
    
    ```
    ERROR: test suite for <class 
'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
        self.setUp()
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
        self.setupContext(ancestor)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
        try_run(context, names)
      File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_GHIWU7/results.txt
    ```
    
    
    
    **Associated Uploads**
    
    **`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_42_48_FTFEG1:`**
    * 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_42_48_FTFEG1/dc_entries.obj)
    * 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_42_48_FTFEG1/failed_plus_exceptions.txt)
    * 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_42_48_FTFEG1/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_network_GHIWU7:`**
    * 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_GHIWU7/failed_plus_exceptions.txt)
    * 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_GHIWU7/results.txt)
    * 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_network_GHIWU7/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_vpc_routers_SEIXAD:`**
    * 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_SEIXAD/failed_plus_exceptions.txt)
    * 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_SEIXAD/results.txt)
    * 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1251/tmp/MarvinLogs/test_vpc_routers_SEIXAD/runinfo.txt)
    
    
    Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`
    
    *Comment created by [`upr comment`](https://github.com/cloudops/upr).*



> Optimize concurrent VM deployment operation on same network
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9180
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9180
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Koushik Das
>            Assignee: Koushik Das
>             Fix For: Future
>
>
> During VM deployment a check is performed to see if VR exists or not. If not 
> it is created - first an entry is allocated in DB for VR and then it is 
> deployed. The allocation logic is placed in a lock (based on network id) so 
> that only one thread does the allocation. But the locking is implemented in a 
> way such that all threads wait on that lock even when VR is already 
> allocated. The correct approach would be to check if VR is allocated or not 
> and acquire lock only when needed.
> This issue is more frequently seen when concurrently deploying VMs in basic 
> zone as all threads try to acquire lock using the same network id. In 
> advanced zone operations are spread across multiple networks and so less 
> frequent.
> Refer to findOrDeployVirtualRouter() in RouterDeploymentDefinition.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to