[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296403#comment-15296403
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9294:
--------------------------------------------

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64229325
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
 ---
    @@ -270,15 +258,15 @@ public PingCommand getCurrentStatus(long id) {
                 _shouldAudit = true;
                 return null;
             }
    -        if (_cmsUserInfo == null || _cmsUserInfo.length < 2) {
    +        if (_cmsUserLogin == null || _cmsUserLogin.isEmpty() || 
_cmsUserPassword == null || _cmsUserPassword.isEmpty()) {
    --- End diff --
    
    Used Strings.isNullOrEmpty since we were using that within that class 
already


> Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9294
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9294
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Third-Party Bugs
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>             Fix For: 4.9.0
>
>
> When destroying a VPC, the VR doesn't get removed from the VSD



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to