[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297599#comment-15297599
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9294:
--------------------------------------------

Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1494#discussion_r64323811
  
    --- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
    @@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long 
routerId, final long guestNe
             sc.setParameters("states", State.Stopped);
             return listBy(sc);
         }
    +
    +    @Override
    +    public List<DomainRouterVO> listIncludingRemovedByVpcId(long vpcId) {
    +        SearchCriteria<DomainRouterVO> sc = VpcSearch.create();
    --- End diff --
    
    QueryBuilder is a better abstraction to use for building queries it saves 
the hardcoding of column names.


> Nuage Plugin : VR doesn't get removed from the VSD when destroying a VPC
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9294
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9294
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Third-Party Bugs
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>             Fix For: 4.9.0
>
>
> When destroying a VPC, the VR doesn't get removed from the VSD



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to