[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361705#comment-15361705
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9422:
--------------------------------------------

Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1602#discussion_r69486019
  
    --- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ---
    @@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm, 
DeployDestination dest) throws Sto
                 disk.setDetails(getDetails(volumeInfo, dataStore));
     
                 vm.addDisk(disk);
    +
    +            // If hypervisor is vSphere, check for clone type setting.
    +            if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
    --- End diff --
    
    So the idea is, instead of creating a clone which is linked to a parent, we 
would create a full clone of the disk. I can see this being useful when you 
don't want to have the overhead of nested reads/writes. Am I correct?
    
    So there are reasons to use a `linked` clone as pointed out by @serg38  and 
there are reasons to use a full clone as well. 


> Granular VMware vm's creation as full clones on HV
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9422
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9422
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: VMware
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> h3. Introduction
> For VMware, It is possible to decide creating VMs as full clones on ESX HV, 
> adjusting {{vmware.create.full.clone}} global setting. We would like to 
> introduce this property as a primary storage detail, and use its value 
> instead of global setting's value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to