[
https://issues.apache.org/jira/browse/CLOUDSTACK-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409902#comment-15409902
]
ASF GitHub Bot commented on CLOUDSTACK-9422:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73742358
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
disk.setDetails(getDetails(volumeInfo, dataStore));
vm.addDisk(disk);
+
+ // If hypervisor is vSphere, check for clone type setting.
+ if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
+ // retrieve clone flag.
+ UserVmCloneType cloneType = UserVmCloneType.linked;
+ Boolean value =
CapacityManager.VmwareCreateCloneFull.valueIn(vol.getPoolId());
+ if (value != null) {
+ if (value.booleanValue() == true)
--- End diff --
Please collapse lines lines 1372 and 1373 into ``if (value != null &&
value)``. The compiler will autobox the ``Boolean`` instance -- removing the
requirement to call ``booleanValue``.
> Granular VMware vm's creation as full clones on HV
> --------------------------------------------------
>
> Key: CLOUDSTACK-9422
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9422
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
>
> h3. Introduction
> For VMware, It is possible to decide creating VMs as full clones on ESX HV,
> adjusting {{vmware.create.full.clone}} global setting. We would like to
> introduce this property as a primary storage detail, and use its value
> instead of global setting's value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
