[
https://issues.apache.org/jira/browse/CLOUDSTACK-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922880#comment-15922880
]
ASF GitHub Bot commented on CLOUDSTACK-8672:
--------------------------------------------
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@nitin-maharana I was looking at the PR.
Do you need to split everything thing there in a different commit?
I think that we still do not have a clear understanding when and how to
separate things in a commit; however, anything like 90+ commits in a PR seems
exaggerated to me.
I like the philosophy that for every commit we should be able to get the
system, build it and use it. This, for instance, would not happen here. Again,
as I said, I think we do not have a clear rule about that, but I would like
others to check this situation as well.
@DaanHoogland, @rhtyd, @swill any thoughts here?
> NCC Integration with CloudStack
> -------------------------------
>
> Key: CLOUDSTACK-8672
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8672
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Devices
> Affects Versions: 4.6.0
> Reporter: Rajesh Battala
> Assignee: Rajesh Battala
> Priority: Critical
> Fix For: Future
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
