[ https://issues.apache.org/jira/browse/CLOUDSTACK-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929679#comment-15929679 ]
ASF GitHub Bot commented on CLOUDSTACK-8672: -------------------------------------------- Github user rajesh-battala commented on the issue: https://github.com/apache/cloudstack/pull/1859 Current commits are in the order of some milestones. As @nitin-maharan told if we squash them into one commit we loose contributions of induviduals. On Thu, Mar 16, 2017 at 7:09 PM, Rohit Yadav <notificati...@github.com> wrote: > @nitin-maharana <https://github.com/nitin-maharana> it becomes easier to > triage changes when changes are confined to a limited number of commits > (ideally one per PR), please squash the commits based on the author (if not > to a single commit) if you don't agree. Ideally, you can also group/squash > commits based on the component/framework/architecture. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/cloudstack/pull/1859#issuecomment-287059366>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA-EAqDvOOOnKfG81zO6sgQ9KmIN0W92ks5rmTufgaJpZM4LUre4> > . > -- Thanks Rajesh Battala > NCC Integration with CloudStack > ------------------------------- > > Key: CLOUDSTACK-8672 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8672 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Devices > Affects Versions: 4.6.0 > Reporter: Rajesh Battala > Assignee: Rajesh Battala > Priority: Critical > Fix For: Future > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)