[
https://issues.apache.org/jira/browse/CLOUDSTACK-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925904#comment-15925904
]
ASF GitHub Bot commented on CLOUDSTACK-9706:
--------------------------------------------
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106133214
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
@@ -191,7 +191,8 @@ public void
processEvent(ObjectInDataStoreStateMachine.Event event) {
s_logger.debug("Failed to update state:" + e.toString());
throw new CloudRuntimeException("Failed to update state: " +
e.toString());
} finally {
- if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+ DataObjectInStore obj = objectInStoreMgr.findObject(this,
this.getDataStore());
+ if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed &&
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --
Is there a possibility for 'obj' to be null? Can you put some comment as to
why there is a need to check 'obj' state not in 'Destroying'?
> Retry deleting snapshot if deleteSnapshot command failed
> ---------------------------------------------------------
>
> Key: CLOUDSTACK-9706
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9706
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
>
> Currently when we delete snapshot then we mark it to be in destroyed state
> first and then we go to delete it on storage if it can be deleted. If the
> deletion of snapshot fails then we never retry to delete it which fills up
> storage.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
