[ https://issues.apache.org/jira/browse/CLOUDSTACK-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925903#comment-15925903 ]
ASF GitHub Bot commented on CLOUDSTACK-9706: -------------------------------------------- Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r103894706 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -1181,6 +1181,17 @@ public boolean configure(String name, Map<String, Object> params) throws Configu @Override public boolean start() { + //destroy snapshots in destroying state + List<SnapshotVO> dsnapshots = _snapshotDao.listAllByStatus(Snapshot.State.Destroying); --- End diff -- Simply use snapshots instead of 'dsnapshots'. > Retry deleting snapshot if deleteSnapshot command failed > --------------------------------------------------------- > > Key: CLOUDSTACK-9706 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9706 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Anshul Gangwar > Assignee: Anshul Gangwar > > Currently when we delete snapshot then we mark it to be in destroyed state > first and then we go to delete it on storage if it can be deleted. If the > deletion of snapshot fails then we never retry to delete it which fills up > storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)