[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577228#comment-16577228
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------

mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412285145
 
 
   Yeah, we basically need to send the DeleteSnapshot command to the hypervisor 
and then remove the corresponding row from cloud.snapshot_store_ref. We then 
want to skip the rest of the stuff around deleting the snapshot from secondary 
storage and those corresponding DB updates.
   
   On Aug 11, 2018, at 10:11 AM, Rafael Weingärtner 
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
   
   
   Ok, so what this means is that the author when creating the PR used the 
snapshotSrv.deleteSnapshot thinking that it would only remove the snapshot in 
the hypervisor (primary storage). However, that method destroys the snapshot in 
ACS, which means removing in the DB and then from both storage systems (primary 
and secondary).
   
   Having said that, what we need is to create a method to remove only 
snapshots from the primary storage only, right? Then, instead of using 
snapshotSrv.deleteSnapshot, we use this new method.
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub<https://github.com/apache/cloudstack/pull/1740#issuecomment-412284787>, 
or mute the 
thread<https://github.com/notifications/unsubscribe-auth/AC4SH0AcyA6vUBNe8Lz5u4Is7_UQ9LJTks5uPwIWgaJpZM4KiQ0->.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9572
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Storage Controller
>    Affects Versions: 4.8.0
>         Environment: Xen Server
>            Reporter: subhash yedugundla
>            Priority: Major
>             Fix For: 4.8.1
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local 
> storage and is transferring this snapshot to secondary storage. But the 
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage 
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and 
> is staying on local storage. So local storage will fill up with unneeded 
> snapshots.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to