[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579105#comment-16579105
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------

mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412720498
 
 
   Sure, open a PR and feel free to tag me when you would like a review. Thanks!
   
   On Aug 13, 2018, at 6:41 PM, Rafael Weingärtner 
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
   
   
   As far as I know, if you migrate a volume from one primary storage to 
another, there should never exist any primary storage-based snapshots of this 
volume after the migration has taken place. That being the case, I don't think 
you should get back primary storage-based snapshots from 
snapshotFactory.getSnapshots that are from different primary storages
   
   I do agree with you, but that is not how it is working right now. Should we 
fix that method then? I can open a PR tomorrow then.
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub<https://github.com/apache/cloudstack/pull/1740#issuecomment-412713958>, 
or mute the 
thread<https://github.com/notifications/unsubscribe-auth/AC4SH9fNf0Es9IA7wUeNBwklFvV7QuY9ks5uQhypgaJpZM4KiQ0->.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9572
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Storage Controller
>    Affects Versions: 4.8.0
>         Environment: Xen Server
>            Reporter: subhash yedugundla
>            Priority: Major
>             Fix For: 4.11
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local 
> storage and is transferring this snapshot to secondary storage. But the 
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage 
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and 
> is staying on local storage. So local storage will fill up with unneeded 
> snapshots.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to