[
https://issues.apache.org/jira/browse/CODEC-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533437
]
Sebb commented on CODEC-55:
---------------------------
The RefinedSoundex class does not need a createThreadSafeABC() method.
Also the behaviour has been changed - previously a null parameter was accepted
for the mapping.
This may be desirable, but it should be documented.
Findbugs points out:
* the field RefinedSoundex.US_ENGLISH_MAPPING needs to be private otherwise it
can be changed outside the class.
* the constructor parameter mapping is externally mutable. The data should be
copied to private array.
There are similar problems with the Soundex class.
> make all "business" method implementations of public API thread safe
> ---------------------------------------------------------------------
>
> Key: CODEC-55
> URL: https://issues.apache.org/jira/browse/CODEC-55
> Project: Commons Codec
> Issue Type: Wish
> Reporter: Qingtian Wang
> Attachments: concurrentCodecs.diff, concurrentQDiff.diff,
> urlcodec.patch
>
>
> Maybe most of the implementations are already thread safe. Just such that
> codec can say so in general...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
