[ 
https://issues.apache.org/jira/browse/CODEC-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533471
 ] 

jwcarman edited comment on CODEC-55 at 10/9/07 1:12 PM:
------------------------------------------------------------

Why would a method like:

String encode(String in, String charset)

be "thread-unsafe"?  If anything, they'd be more thread-safe, since the 
parameter is used (which is a local variable as opposed to a member variable) 
for the charset rather than the member variable.  

I agree that we really should just add some documentation.  This appears to be 
a non-issue, IMHO.  Most folks wouldn't be changing stuff on the fly anyway.

      was (Author: jwcarman):
    Why would a method like:

String encode(String in, String charset)

be "thread-unsafe"?  If anything, they'd be more thread-safe, since the 
parameter is used (which is a local variable as opposed to a member variable) 
for the charset rather than the member variable.  
  
> make all "business" method implementations of public API thread safe 
> ---------------------------------------------------------------------
>
>                 Key: CODEC-55
>                 URL: https://issues.apache.org/jira/browse/CODEC-55
>             Project: Commons Codec
>          Issue Type: Wish
>            Reporter: Qingtian Wang
>         Attachments: concurrentCodecs.diff, concurrentQDiff.diff, 
> urlcodec.patch
>
>
> Maybe most of the implementations are already thread safe. Just such that 
> codec can say so in general...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to