[ 
https://issues.apache.org/jira/browse/COLLECTIONS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554588
 ] 

Dave Meikle commented on COLLECTIONS-194:
-----------------------------------------

I agree with James about TransformerUtils.nopTransformer() being slightly more 
elegant but I did make the decision with regards to passing null based on the 
fact that this indirection will cause a slight delay.

With regards to the Null Pointer Exceptions I have removed the null checks for 
the Map and Collection, but have left them in for the Tranformers as this is 
what TransformedMap does. That said I have no strong opinion either way on 
removing these checks if you guys would prefer.

Cheers,
Dave

> Add populateMap() methods to MapUtils
> -------------------------------------
>
>                 Key: COLLECTIONS-194
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-194
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: Map
>         Environment: Operating System: All
> Platform: All
>            Reporter: James Carman
>            Priority: Minor
>             Fix For: 3.3
>
>         Attachments: COLLECTIONS-192.patch
>
>
> Add the following methods to MapUtils...
> public static void populateMap( Map map, Collection objects, Transformer
> keyTransformer );
> public static void populateMap( Map map, Collection objects, Transformer
> keyTransformer, Transformer valueTransformer );

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to