[ 
https://issues.apache.org/jira/browse/MATH-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557995#action_12557995
 ] 

Luc Maisonobe commented on MATH-173:
------------------------------------

Sorry for my bad explanation, I am not a native english speaker and I often 
write confusing things.

What I meant was that the original HashTable seemed to have two 
purposes/features :
 - provide a name versus data array mapping
 - act as a container for multiple (named) categories

For clarity purposes, I don't think these features should be handled together. 
The names are not used as a "key" to access the data. They are used as a 
property associated with each category, which allows to display a meaningful 
error message (which is a very good thing) when one category is found to 
contains too few data.

For clarity I prefer to separate these features. On the one hand, tthe Category 
class I proposed does provide the name/data association in a strongly typed way 
which is always good. I do like strong typing. In fact I could even have 
proposed to wrap only the double array in a Category. On the other hand, 
multiple categories is done by putting the Category instances in some container 
(a Container implementation, a Category[], whatever).

Accepting both double[] and Category as the container elements and checking 
this in the argument checking code seems odd to me. It raises object-oriented 
design concerns. Once we have chosen the type (either double[] or Category), we 
should stick with it. This would also allow in a future version to use generics 
with fewer changes on user side when we decide to drop support for 1.3.

There are no deadline, this is a voluntarily driven project. I would of course 
be very happy to have this soon, since this issue as well as issue MATH-176 are 
the two last ones we wanted to fix before releasing version 1.2.

> One-way ANOVA
> -------------
>
>                 Key: MATH-173
>                 URL: https://issues.apache.org/jira/browse/MATH-173
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: Nightly Builds
>            Reporter: Bob MacCallum
>             Fix For: 1.2
>
>         Attachments: Anova.java, AnovaImpl.java, AnovaTest.java
>
>
> Here is some proposed code to add one-way ANOVA tests to commons-math
> I will be attaching
> src/test/org/apache/commons/math/stat/inference/AnovaTest.java
> src/java/org/apache/commons/math/stat/inference/Anova.java
> src/java/org/apache/commons/math/stat/inference/AnovaImpl.java
> I followed TTest as a style guide.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to