[
https://issues.apache.org/jira/browse/LANG-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562494#action_12562494
]
Sebb commented on LANG-180:
---------------------------
The Exception messages could be improved, e.g.
"Lengths don't match: " - which lengths?
The above should perhaps be an IllegalArgumentException rather than
IndexOutOfBoundsException, as it's not an actual out of bounds, more a
potential out of bounds - but either type will do.
" is under 0: " => " is less than 0:"
I don't like the names "repl" and "with"; particularly "repl" could mean the
replacement text rather than the replaced text.
RE engines tend to use words such as:
Perl:
searchlist
replacementlist
ORO:
pattern
replacement
Java has String.replace(regex, replacement)
In all cases, "replacement" is used.
Seems to me that searchlist and replacementlist would be unambiguous as well as
descriptive.
> [lang] adding a StringUtils.replace method that takes an array or List of
> replacement strings
> ---------------------------------------------------------------------------------------------
>
> Key: LANG-180
> URL: https://issues.apache.org/jira/browse/LANG-180
> Project: Commons Lang
> Issue Type: Improvement
> Environment: Operating System: other
> Platform: Other
> Reporter: Chris
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LANG-180.patch, LANG-180.patch, StringUtilsAndText.java
>
>
> I have the situation where I have a String template with a dozen replacements
> I need to make. When I loop through and use StringUtils.replace each time,
> it
> has to make a StringBuffer of the whole template each time. I think we could
> make this more efficient if we had a replace() method which took an array of
> Strings to search for, and an array of Strings to replace with (or we could
> use a Collection or List or something). This way we could possibly do the
> replace in one StringBuffer result.
> One issue is if the replacement text has Strings to be replaced, do we
> iterate
> through again until there are no Strings to search for? Based on your
> replaceChars(String str, String searchChars, String replaceChars) method, I
> assume the answer is no, but we could have a boolean flag to have it both
> ways.
> I can write this for you if you are interested, please let me know.
> Thanks!
> Chris
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
