[
https://issues.apache.org/jira/browse/IO-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666136#action_12666136
]
Jukka Zitting commented on IO-191:
----------------------------------
Replying to Peter.
{quote}
I don't imagine multiple patches are easier to apply.
{quote}
As noted above, we probably don't want to apply all the changes in the patch.
Having smaller patches would make it easier to selectively apply the changes
you propose.
{quote}
> Changing single character string literals to character literals in string
> concatenations.
This is a fair comment. If you feel its worth reviewing on a case by case basis
I am happy to do this.
{quote}
I don't think it's worth the effort, but perhaps I'm missing some really
convincing reason why we should do this.
{quote}
> why are some parts of the expression strings and other characters.
Is this a question you would like me to answer or you are just raising this as
a hypothetical question someone might ask.
{quote}
Just a hypothetical question that a future developer that looks at the code
might think about.
> Possible improvements using static analysis.
> --------------------------------------------
>
> Key: IO-191
> URL: https://issues.apache.org/jira/browse/IO-191
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-io-static-analysis.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
