[
https://issues.apache.org/jira/browse/IO-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666159#action_12666159
]
Jukka Zitting commented on IO-191:
----------------------------------
Sebb, you're right, the collection field should be volatile. My assumption (not
true for AndFileFilter) was that the collection itself is immutable, so partial
updates would not have been a problem.
Anyway, my objection on grounds of thread safety is moot since the
AndFileFilter is not (and probably does not need to be) thread-safe. So making
the field final and using Collection.clear() is fine by me.
> Possible improvements using static analysis.
> --------------------------------------------
>
> Key: IO-191
> URL: https://issues.apache.org/jira/browse/IO-191
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-io-static-analysis.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
