[
https://issues.apache.org/jira/browse/SANDBOX-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681617#action_12681617
]
Stefan Bodewig commented on SANDBOX-294:
----------------------------------------
I'd rather turn this in a more general "think about protected API" task that
applies to some things in the zip package as well.
As the checkstyle comments indicate, these fields are protected because they
used to be that way in early versions of Ant - this is a backwards
compatibility requirement compress doesn't share, so we are free to change
things that don't really make sense (we don't want subclasses to change the
buffer, for example).
> The field TarArchiveInputStream.in is never read locally
> --------------------------------------------------------
>
> Key: SANDBOX-294
> URL: https://issues.apache.org/jira/browse/SANDBOX-294
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Compress
> Reporter: Sebb
> Priority: Minor
>
> The field TarArchiveInputStream.in is never read locally.
> Is there any need for this field, which is stored by the constructor and also
> passed to the TarBuffer constructor?
> Also, the fields "buffer" and "oneBuf" could be made final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
