[
https://issues.apache.org/jira/browse/SANDBOX-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681886#action_12681886
]
Sebb commented on SANDBOX-294:
------------------------------
Agreed. Now is the time to grab back as many of the non-private mutable fields
as possible.
It's much easier to relax the requirements later - should it really prove
necessary.
If a mutable field is not private, there should be a (documented) good reason
for making it so, and any synchronisation requirements should be stated.
> The field TarArchiveInputStream.in is never read locally
> --------------------------------------------------------
>
> Key: SANDBOX-294
> URL: https://issues.apache.org/jira/browse/SANDBOX-294
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Compress
> Reporter: Sebb
> Priority: Minor
>
> The field TarArchiveInputStream.in is never read locally.
> Is there any need for this field, which is stored by the constructor and also
> passed to the TarBuffer constructor?
> Also, the fields "buffer" and "oneBuf" could be made final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
