[ 
https://issues.apache.org/jira/browse/COMPRESS-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693421#action_12693421
 ] 

Torsten Curdt commented on COMPRESS-61:
---------------------------------------

Static singleton's are the "old school" way of doing things. Statics usually 
cause more problems that they help. If someone is concerned about object 
creations he can cache the factories himself. But usually modern JVMs have 
become so efficient in handling object creations (especially if it's a light 
weight object like this) that I consider it a design mistake to have a static 
accessor as part of the API.

> ArchiveStreamFactory could have static methods as well
> ------------------------------------------------------
>
>                 Key: COMPRESS-61
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-61
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Sebb
>
> ArchiveStreamFactory currently has to be instantiated in order to use it.
> The methods have to be instance methods in order for subclasses to override 
> them, but until that is done (will it ever be done?) it seems a bit 
> unnecessary to create an instance of the class.
> Perhaps there could be a private static instance of the class that could be 
> used with public static methods?
> The same considerations apply to the other factories.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to