[ 
https://issues.apache.org/jira/browse/COMPRESS-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693449#action_12693449
 ] 

Torsten Curdt commented on COMPRESS-61:
---------------------------------------

I really don't see the big benefit in adding the static accessor. The code to 
cache the factory yourself is so minimal that I don't see why we should add 
this to the API. All that we are left with is legacy code that barely saves 
more than 2 lines of user code. Plus this falls down as soon as anyone extends 
the factory anyway. Let's not go there.

> ArchiveStreamFactory could have static methods as well
> ------------------------------------------------------
>
>                 Key: COMPRESS-61
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-61
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Sebb
>
> ArchiveStreamFactory currently has to be instantiated in order to use it.
> The methods have to be instance methods in order for subclasses to override 
> them, but until that is done (will it ever be done?) it seems a bit 
> unnecessary to create an instance of the class.
> Perhaps there could be a private static instance of the class that could be 
> used with public static methods?
> The same considerations apply to the other factories.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to