[
https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=585565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585565
]
ASF GitHub Bot logged work on TEXT-202:
---------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 05:41
Start Date: 20/Apr/21 05:41
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616359101
##########
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##########
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
buffer[size++] = 't';
buffer[size++] = 'r';
buffer[size++] = 'u';
- buffer[size++] = 'e';
} else {
ensureCapacity(size + 5);
buffer[size++] = 'f';
buffer[size++] = 'a';
buffer[size++] = 'l';
buffer[size++] = 's';
- buffer[size++] = 'e';
}
+ buffer[size++] = 'e';
Review comment:
I prefer the other version, even though this one indeed reduces the
duplication, the other version clearly shows that we have `true` and `false`,
without the dev having to think why `tru` and `fals`, just to find the `e` was
set out the `if/else` statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 585565)
Time Spent: 20m (was: 10m)
> Extract duplicate code
> ----------------------
>
> Key: TEXT-202
> URL: https://issues.apache.org/jira/browse/TEXT-202
> Project: Commons Text
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Extract duplicate code in conditions and reused
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
