[
https://issues.apache.org/jira/browse/TEXT-202?focusedWorklogId=586153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586153
]
ASF GitHub Bot logged work on TEXT-202:
---------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 20:07
Start Date: 20/Apr/21 20:07
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616997571
##########
File path: src/main/java/org/apache/commons/text/StringTokenizer.java
##########
@@ -848,11 +844,9 @@ private int readWithQuotes(final char[] srcChars, final
int start, final int len
pos += trimmedLen;
continue;
}
-
- // copy regular character from outside quotes
- workArea.append(srcChars[pos++]);
- trimStart = workArea.size();
}
+ workArea.append(srcChars[pos++]);
Review comment:
Ditto here about the comment that was removed :+1:
##########
File path: src/main/java/org/apache/commons/text/StrTokenizer.java
##########
@@ -842,10 +838,9 @@ private int readWithQuotes(final char[] srcChars, final
int start, final int len
continue;
}
- // copy regular character from outside quotes
- workArea.append(srcChars[pos++]);
- trimStart = workArea.size();
}
+ workArea.append(srcChars[pos++]);
Review comment:
@arturobernalg can you add back the comment above these lines, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586153)
Time Spent: 1h 20m (was: 1h 10m)
> Extract duplicate code
> ----------------------
>
> Key: TEXT-202
> URL: https://issues.apache.org/jira/browse/TEXT-202
> Project: Commons Text
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Extract duplicate code in conditions and reused
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
