bodewig commented on a change in pull request #194:
URL: https://github.com/apache/commons-compress/pull/194#discussion_r637402822
##########
File path:
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
##########
@@ -937,7 +936,7 @@ private void sanityCheckSubStreamsInfo(final ByteBuffer
header, final ArchiveSta
for (int i = 0; i < stats.numberOfFolders; i++) {
numUnpackSubStreamsPerFolder.add(assertFitsIntoNonNegativeInt("numStreams",
readUint64(header)));
}
- stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().collect(Collectors.summingLong(Integer::longValue));
+ stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().mapToLong(Integer::longValue).sum();
Review comment:
what is the advantage of doing it this way? This is a curious question.
When I wrote the code I considered both options and considered the later to
better express my intention - but I'm more than willing to change it if this is
not just a metter of taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
