bodewig commented on a change in pull request #194:
URL: https://github.com/apache/commons-compress/pull/194#discussion_r637409450
##########
File path:
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
##########
@@ -937,7 +936,7 @@ private void sanityCheckSubStreamsInfo(final ByteBuffer
header, final ArchiveSta
for (int i = 0; i < stats.numberOfFolders; i++) {
numUnpackSubStreamsPerFolder.add(assertFitsIntoNonNegativeInt("numStreams",
readUint64(header)));
}
- stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().collect(Collectors.summingLong(Integer::longValue));
+ stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().mapToLong(Integer::longValue).sum();
Review comment:
well, the examples are quite different from this case and I agree with
all of them.
Please do me a favor and separate this change from the rest of the PR and
the other team members can chime in with their opinion. I'm not totally against
the change just consider it non-necessary. "readablity" is not really an
objective measure as you can tell from our conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
