[ 
https://issues.apache.org/jira/browse/TEXT-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372196#comment-17372196
 ] 

Bruno P. Kinoshita commented on TEXT-207:
-----------------------------------------

Hi [~mattjuntunen]

>Side note: Is there a place to put my JMH benchmarks in commons-text? In 
>numbers and geometry, we have them in examples modules.

Good question, we still don't have any JMH benchmarks in commons-text. Maybe 
add to the test directory, with a package like `performance`, or `perf` like 
CSV does? 
[https://github.com/apache/commons-csv/tree/a2e06fe45bddd8c51ed7f7b2f1b84bc7c8a1ce4d/src/test/java/org/apache/commons/csv/perf]

If the test takes more than a few (30?) seconds, probably exclude it by 
default, and let the dev/user decide when to run it, as in CSV 
[https://github.com/apache/commons-csv/blob/a2e06fe45bddd8c51ed7f7b2f1b84bc7c8a1ce4d/pom.xml#L196-L202]

What do you think?

Thanks!

Bruno

> Include DoubleFormats utility from commons-geometry
> ---------------------------------------------------
>
>                 Key: TEXT-207
>                 URL: https://issues.apache.org/jira/browse/TEXT-207
>             Project: Commons Text
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> commons-geometry currently contains a 
> [DoubleFormats|https://github.com/apache/commons-geometry/blob/master/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/utils/DoubleFormats.java]
>  utility class in the {{commons-geometry-io-core}} module that produces 
> standardized string representations of doubles for use in text-based data 
> formats. It has the following features:
> - It is completely thread-safe.
> - It produces string in scientific, engineering, plain, or mixed (plain or 
> scientific depending on value) formats.
> - Performance is comparable to {{DecimalFormat}} and {{BigDecimal}}.
> As mentioned on the dev mailing list, I believe that this class has broader 
> applicability than just geometric data formats and would be a good fit for 
> commons-text.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to