SethFalco opened a new pull request #93: URL: https://github.com/apache/commons-beanutils/pull/93
Just wanted to clean up some tests, but PR is also a proposal and demonstration before I do the rest of the repository. There are 2 changes I'd like to make: * Upgrade to JUnit 5 * Reduce code setup, for example in `MethodUtilsTestCase.java`, we can just use `String` instead of creating a custom `A` class just for the test. Upgrading to JUnit 5 has a few notable benefits: * We can use `assertAll` when there are multiple assertions. (So we do all assertions, currently if one fails then the rest can't run until `mvn test` is run again.) * Significantly less code surface, just doing 2 files has already removed 337 lines. * Significantly less boilerplate for test classes. * JUnit 4+ offers great failure messages and exception handling by default, so there's no need to handle that. * Structure will be more familiar to developers that started in recent years. (including myself) --- This could be done in 2 ways: * Over time in multiple PRs, so each change is smaller. (This will require having 3 dependencies for testing until it's finished.) * All at once in one PR. (We can replace JUnit 4 with JUnit 5, but it'll be one hell of a large PR.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
